Re: [PATCH 4/6] ce4100: Add errata fixes for UART on CE4100

From: Thomas Gleixner
Date: Thu Nov 11 2010 - 07:06:52 EST


On Thu, 11 Nov 2010, Dirk Brandewie wrote:

> On 11/11/2010 03:47 AM, Thomas Gleixner wrote:
> > On Thu, 11 Nov 2010, Dirk Brandewie wrote:
> >
> > > On 11/11/2010 03:34 AM, Thomas Gleixner wrote:
> > > >
> > > >
> > > > > + * Over ride the legacy port configuration that comes from
> > > > > + * asm/serial.h. Using the ioport driver then switching to the
> > > > > + * PCI memmaped driver hangs the IOAPIC
> > > > > + */
> > > > > + if (up->iotype != UPIO_MEM32) {
> > > > > + up->uartclk = 14745600;
> > > > > + up->mapbase = 0xdffe0200;
> > > >
> > > > What does the uartclk, mapbase fixups in the CONFIG_EARLY_PRINTK=n
> > > > case ?
> > > >
> > > This is setup in the PCI driver patch #3 in the series
> >
> > I just can't find it there, that's why I'm asking :)
> The weird clock is dealt with in:
> + [pbn_ce4100_1_115200] = {
> + .flags = FL_BASE0,
> + .num_ports = 1,
> + .base_baud = 921600,
> + .reg_shift = 2,
> + },
>
> That map base is setup in the generic pci driver in setup_port(). I didn't
> need to do anything special.

Thanks for the clarification.

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/