Re: [PATCH 8/19]: SCST SYSFS interface implementation

From: Greg KH
Date: Thu Nov 11 2010 - 07:24:00 EST


On Thu, Nov 11, 2010 at 11:59:28AM +0200, Boaz Harrosh wrote:
> 4. Exactly Like 3 but without the extra kref member
> Only x_put() changes and x_kref_release() now receives
> an x_object
>
> int x_put(struct object_x *x)
> {
> if (kobject_put(&x->kobj) == 1)
> // Like above [3] x_kref_release()
> x_kref_release(x);
> }

This is racy, please never do this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/