Re: [PATCH v1.3 2/4] key: add tpm_send command

[David Howells]

Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> Reviewd-by: Mimi Zohar <zohar@xxxxxxxxxxxxxx>

You've missed an 'e'.

> +int tpm_send(u32 chip_num, char *cmd, int buflen)
> +{
> ...
> +	rc = transmit_cmd(chip, (struct tpm_cmd_t *)cmd, buflen,
> +			  "attempting tpm_cmd");

Make cmd 'void *' to obviate the cast.  Preferably it should be const too.

> +	module_put(chip->dev->driver->owner);

Where's the corresponding module_get()?  I suspect this should be wrapped to
match tpm_chip_find_get().

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/