Re: [PATCH v1.3 1/4] lib: hex2bin converts ascii hexadecimalstring to binary

[Mimi Zohar]

On Thu, 2010-11-11 at 19:48 +0000, David Howells wrote:
> Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > +void hex2bin(unsigned char *mem, char *buf, int count)
> 
> I think this needs a little adjustment.  I would recommend something like the
> following declaration:
> 
> 	void hex2bin(u8 *buf, const char *data, size_t count)
> 
> since the output data is binary (so use u8*), you're only reading the source
> data (so should use a const pointer) and you don't want to see a negative
> count (so use size_t).

right, thanks.

> Also, I'd suggest calling the source arg 'data' and the output arg 'buf' or
> maybe src/dst.
> 
> David

Definitely better. (Remnant from kgdb_hex2mem() naming.)

thanks,

Mimi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/