RE: [PATCH 07/07] ARM: Use shared GIC entry macros on OMAP

[Shilimkar, Santosh]

> -----Original Message-----
> From: Magnus Damm [mailto:magnus.damm@xxxxxxxxx]
> Sent: Friday, November 12, 2010 1:52 PM
> To: linux@xxxxxxxxxxxxxxxx
> Cc: kgene.kim@xxxxxxxxxxx; kmpark@xxxxxxxxxxxxx; konkers@xxxxxxxxxxx;
> tony@xxxxxxxxxxx; adharmap@xxxxxxxxxxxxxx; avorontsov@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; srinidhikasagar@xxxxxxxxx; dwalker@xxxxxxxxxxxxxx;
> Shilimkar, Santosh; ccross@xxxxxxxxxxx; olof@xxxxxxxxx; Magnus Damm;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 07/07] ARM: Use shared GIC entry macros on OMAP
> 
> From: Magnus Damm <damm@xxxxxxxxxxxxx>
> 
> Common GIC entry macro for omap
> 
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx>
Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> ---
> 
>  arch/arm/mach-omap2/include/mach/entry-macro.S |   92 ++++++++-----------
> -----
>  1 file changed, 31 insertions(+), 61 deletions(-)
> 
> --- 0001/arch/arm/mach-omap2/include/mach/entry-macro.S
> +++ work/arch/arm/mach-omap2/include/mach/entry-macro.S	2010-11-12
> 16:10:51.000000000 +0900
> @@ -105,6 +105,35 @@ omap_irq_base:	.word	0
>  9999:
>  		.endm
> 
> +#ifdef CONFIG_SMP
> +		/* We assume that irqstat (the raw value of the IRQ
> acknowledge
> +		 * register) is preserved from the macro above.
> +		 * If there is an IPI, we immediately signal end of interrupt
> +		 * on the controller, since this requires the original irqstat
> +		 * value which we won't easily be able to recreate later.
> +		 */
> +
> +		.macro test_for_ipi, irqnr, irqstat, base, tmp
> +		bic	\irqnr, \irqstat, #0x1c00
> +		cmp	\irqnr, #16
> +		it	cc
> +		strcc	\irqstat, [\base, #GIC_CPU_EOI]
> +		it	cs
> +		cmpcs	\irqnr, \irqnr
> +		.endm
> +
> +		/* As above, this assumes that irqstat and base are preserved
> */
> +
> +		.macro test_for_ltirq, irqnr, irqstat, base, tmp
> +		bic	\irqnr, \irqstat, #0x1c00
> +		mov 	\tmp, #0
> +		cmp	\irqnr, #29
> +		itt	eq
> +		moveq	\tmp, #1
> +		streq	\irqstat, [\base, #GIC_CPU_EOI]
> +		cmp	\tmp, #0
> +		.endm
> +#endif	/* CONFIG_SMP */
> 
>  #else	/* MULTI_OMAP2 */
> 
> @@ -141,74 +170,15 @@ omap_irq_base:	.word	0
> 
> 
>  #ifdef CONFIG_ARCH_OMAP4
> +#include <asm/hardware/entry-macro-gic.S>
> 
>  		.macro  get_irqnr_preamble, base, tmp
>  		ldr     \base, =OMAP4_IRQ_BASE
>  		.endm
> 
> -		/*
> -		 * The interrupt numbering scheme is defined in the
> -		 * interrupt controller spec.  To wit:
> -		 *
> -		 * Interrupts 0-15 are IPI
> -		 * 16-28 are reserved
> -		 * 29-31 are local.  We allow 30 to be used for the watchdog.
> -		 * 32-1020 are global
> -		 * 1021-1022 are reserved
> -		 * 1023 is "spurious" (no interrupt)
> -		 *
> -		 * For now, we ignore all local interrupts so only return an
> -		 * interrupt if it's between 30 and 1020.  The test_for_ipi
> -		 * routine below will pick up on IPIs.
> -		 * A simple read from the controller will tell us the number
> -		 * of the highest priority enabled interrupt.
> -		 * We then just need to check whether it is in the
> -		 * valid range for an IRQ (30-1020 inclusive).
> -		 */
> -		.macro  get_irqnr_and_base, irqnr, irqstat, base, tmp
> -		ldr     \irqstat, [\base, #GIC_CPU_INTACK]
> -
> -		ldr     \tmp, =1021
> -
> -		bic     \irqnr, \irqstat, #0x1c00
> -
> -		cmp     \irqnr, #29
> -		cmpcc   \irqnr, \irqnr
> -		cmpne   \irqnr, \tmp
> -		cmpcs   \irqnr, \irqnr
> -		.endm
>  #endif
> -#endif	/* MULTI_OMAP2 */
> -
> -#ifdef CONFIG_SMP
> -		/* We assume that irqstat (the raw value of the IRQ
> acknowledge
> -		 * register) is preserved from the macro above.
> -		 * If there is an IPI, we immediately signal end of interrupt
> -		 * on the controller, since this requires the original irqstat
> -		 * value which we won't easily be able to recreate later.
> -		 */
> -
> -		.macro test_for_ipi, irqnr, irqstat, base, tmp
> -		bic	\irqnr, \irqstat, #0x1c00
> -		cmp	\irqnr, #16
> -		it	cc
> -		strcc	\irqstat, [\base, #GIC_CPU_EOI]
> -		it	cs
> -		cmpcs	\irqnr, \irqnr
> -		.endm
> -
> -		/* As above, this assumes that irqstat and base are preserved
> */
> 
> -		.macro test_for_ltirq, irqnr, irqstat, base, tmp
> -		bic	\irqnr, \irqstat, #0x1c00
> -		mov 	\tmp, #0
> -		cmp	\irqnr, #29
> -		itt	eq
> -		moveq	\tmp, #1
> -		streq	\irqstat, [\base, #GIC_CPU_EOI]
> -		cmp	\tmp, #0
> -		.endm
> -#endif	/* CONFIG_SMP */
> +#endif	/* MULTI_OMAP2 */
> 
>  		.macro	irq_prio_table
>  		.endm
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/