Re: [PATCH v1.3 2/4] key: add tpm_send command

[David Howells]

Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> > > +	module_put(chip->dev->driver->owner);
> > 
> > Where's the corresponding module_get()?  I suspect this should be wrapped to
> > match tpm_chip_find_get().
> > 
> > David
> 
> The module_get() is in tpm_chip_find_get(), which is just a helper.
> (It's used this way throughout tpm.c)

I'd make a function tpm_chip_find_put() just to wrap module_put() and then
place it with tpm_chip_find_get() in the sources.  That makes it easier to see
what's going on.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/