Re: [PATCH 0/2] x86: Remove old nmi_watchdog

[Cyrill Gorcunov]

On Fri, Nov 12, 2010 at 11:22:22AM -0500, Don Zickus wrote:
>
> Ingo asked me to remove the old nmi_watchdog to minimize the amount of
> code duplication we have to do for recent fixes.  All the functionality
> needed by the old nmi watchdog should be available in perf now.
> 

 Hi Don, moving out old nmi-watchdog in a sake of new perf based one is
definitely a win I believe. And I didn't find anything suspicious in patch
series as well.

Though it's a bit pity that we eventually drop old io-apic based watchdog ;)
I never used it personally since apic on mine cpu works well enough but still
I think the io-apic watchdog code was pretty interesting to read and I believe
it worked well with old pit timer.

> Compile tested for 32/64 bit with the lockup detector turned on and off.
> Tested on 32/64 bit machines to make sure they still boot properly.

ok, great done!

 Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/