Re: [PATCH v1.3 2/4] key: add tpm_send command

[David Howells]

David Safford <safford@xxxxxxxxxxxxxx> wrote:

> David, does this look ok to you? If so, I will do two patches, one to
> fix the helper name throughout the existing tpm.c, and then a new
> version of the tpm_send patch which uses the new name.

I prefer my suggestion: Wrapping the module_put() up so that you don't see it
directly.  Then you don't need to alter tpm_chip_find_get().  I'll argue that
you don't need to know how tpm_chips are got/put, except in the code that
wraps it.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/