Re: [PATCH] eeepc-wmi: fix compiler warning

[Corentin Chary]

On Wed, Nov 3, 2010 at 7:43 PM, Chris Bagwell <chris@xxxxxxxxxxxxxx> wrote:
> On Wed, Nov 3, 2010 at 1:14 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>> This fixes the following:
>>
>> ÂCC [M] Âdrivers/platform/x86/eeepc-wmi.o
>> drivers/platform/x86/eeepc-wmi.c:322: warning: initialization from incompatible pointer type
>>
>> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
>> ---
>>
>> Âdrivers/platform/x86/eeepc-wmi.c | Â Â4 ++--
>> Â1 files changed, 2 insertions(+), 2 deletions(-)
>>
>>
>> diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
>> index 462ceab..0d50fbb 100644
>> --- a/drivers/platform/x86/eeepc-wmi.c
>> +++ b/drivers/platform/x86/eeepc-wmi.c
>> @@ -298,8 +298,8 @@ static void eeepc_wmi_notify(u32 value, void *context)
>> Â Â Â Âkfree(obj);
>> Â}
>>
>> -static int store_cpufv(struct device *dev, struct device_attribute *attr,
>> - Â Â Â Â Â Â Â Â Â Â Âconst char *buf, size_t count)
>> +static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Âconst char *buf, size_t count)
>> Â{
>> Â Â Â Âint value;
>> Â Â Â Âstruct acpi_buffer input = { (acpi_size)sizeof(value), &value };
>> --
>
> Opps. ÂSorry, I missed that warning. Âssize_t is obviously correct return value.
>
> Reviewed-by: Chris Bagwell <chris@xxxxxxxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>

Just queued the same patch on my repo, I should have read the list first.

Matthew can you queue this one for next batch ?
Thanks,

-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/