Re: [PATCH] cleanup kswapd()

[KOSAKI Motohiro]

> On Sun, 14 Nov 2010, KOSAKI Motohiro wrote:
> 
> > 
> > Currently, kswapd() function has deeper nest and it slightly harder to
> > read. cleanup it.
> > 
> > Cc: Mel Gorman <mel@xxxxxxxxx>
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> > ---
> >  mm/vmscan.c |   71 +++++++++++++++++++++++++++++++---------------------------
> >  1 files changed, 38 insertions(+), 33 deletions(-)
> > 
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index 8cc90d5..82ffe5f 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -2364,6 +2364,42 @@ out:
> >  	return sc.nr_reclaimed;
> >  }
> >  
> > +void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
> 
> Shouldn't this be
> 
>   static void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
> 
> ??

Right. thank you.
I'll respin.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/