Re: [PATCH, RFC] usbmon: correct computing of the ISO packets withmmap

[Pete Zaitcev]

On Sun, 14 Nov 2010 22:01:58 -0500 (EST)
Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> > + * This is the look-ahead pass in case of 'Ci', when actual_length cannot
> > + * be used to determine the length of the whole contiguous buffer.
> 
> Shouldn't the comment say "Cz" instead of "Ci"?

Turned out it's actually "C Zi".

> > +	while (ndesc-- != 0) {
> > +		if (fp->status == 0 && fp->actual_length != 0) {
> 
> I'd leave out the fp->status == 0 test.  It's not relevant; a buffer 
> can contain valid data even if the final status isn't 0.

That's a good point, however is actual_length filled in such case?
I thought it was either one or the other.

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/