Re: [PATCH] x86, mrst: The shutdown for MRST requires the SCU IPCmechanism

From: Randy Dunlap
Date: Mon Nov 15 2010 - 13:14:57 EST


On Mon, 15 Nov 2010 17:31:19 +0000 Alan Cox wrote:

> From: Alan Cox <alan@xxxxxxxxxxxxxxx>
>
> Fix the build failure reported by Randy Dunlap
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> ---
>
> arch/x86/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9e71608..afe50ec 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -387,6 +387,7 @@ config X86_MRST
> select APB_TIMER
> select I2C
> select SPI
> + select INTEL_SCU_IPC
> ---help---
> Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
> Internet Device(MID) platform. Moorestown consists of two chips:

Hi,
Additionally using this line from my patch:

+ select X86_PLATFORM_DEVICES

will avoid this warning (with your patch applied):

warning: (X86_MRST && PCI && PCI_GOANY && X86_32 && X86_EXTENDED_PLATFORM && X86_IO_APIC) selects INTEL_SCU_IPC which has unmet direct dependencies
(X86 && X86_PLATFORM_DEVICES && X86_MRST)

which is due to the hierarchical menu structure.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/