Re: [RFC][PATCH 2/8] perf, arch: Use early_initcall() for all archpmu implementations

[Will Deacon]

Hi Peter,

On Thu, 2010-11-25 at 14:47 +0000, Peter Zijlstra wrote:
> > So do I create a perf_initcall() or is there another solution that
> > avoids things like calling the watchdog code from all arch init code?
> 
> How about something like these? After this we could even look at making
> the watchdog code an explicit init in main.c right after
> do_perf_initcalls() (or later if it requires more to be up and running).
> 
What tree/branch are these patches taken against? They don't seem
to apply against -rc3 or tip/master. Anyway, I currently have some
pending patches to split up the monolithic perf_event.c we have for ARM
so that different PMU implementations can live in different files (in
the same way that x86 does it). This might mean that your initcall patch
no longer applies because it will be a couple of thousand lines higher
up in the file.

The patches are available here:

git://linux-arm.org/linux-2.6-wd.git perf-split

I'll put these into Russell's patch system today so they should be
candidates for 2.6.38.
> 
> Hrm,. except that it all builds but doesn't seem to actually work, I
> guess I need more magics to make the perf_initcall() thing work.
> 
> /me goes investigate

Good luck!

Will



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/