Re: linux-next: Tree for November 25 (snd/soc/codecs)

[Randy Dunlap]

On Thu, 25 Nov 2010 16:49:29 +1100 Stephen Rothwell wrote:

> Hi all,
> 
> Changes since 20101124:


When CONFIG_I2C is not enabled:

sound/soc/codecs/wm8737.c:521:error: 'i2c_master_send' undeclared (first use in this function)

but CONFIG_SND_SOC_I2C_AND_SPI=m
and CONFIG_SND_SOC_WM8737=m

Should SND_SOC_I2C_AND_SPI depend on I2C && SPI ??

config SND_SOC_I2C_AND_SPI
	tristate
	default m if I2C=m
	default y if I2C=y
	default y if SPI_MASTER=y


This doesn't handle the I2C disabled case, hence the build error.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/