Re: [PATCH 3/8] ARM: VExpress: Switch to generic SCU routines

[Russell King - ARM Linux]

On Tue, Nov 30, 2010 at 08:17:01PM +0300, Anton Vorontsov wrote:
> +/* If there are more than one CPU let them know where to start. */
> +static void __init smp_point_cpus(void)
> +{
> +	if (num_present_cpus() <= 1)
> +		return;
>  
> -	for (i = 0; i < ncores; i++)
> -		set_cpu_possible(i, true);
> +	writel(~0, MMIO_P2V(V2M_SYS_FLAGSCLR));
> +	writel(BSYM(virt_to_phys(scu_secondary_startup)),
> +	       MMIO_P2V(V2M_SYS_FLAGSSET));
>  }

I don't see the point of separating this code from the code below.  It
doesn't seem to bring any benefit.  Could you explain why it's necessary
to separate this?

>  void __init smp_prepare_cpus(unsigned int max_cpus)
>  {
...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/