Re: [PATCH v3 3/3] Prevent activation of page in madvise_dontneed
From: Minchan Kim
Date: Tue Nov 30 2010 - 19:50:55 EST
On Tue, Nov 30, 2010 at 8:35 PM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> On Tue, Nov 30, 2010 at 12:23:21AM +0900, Minchan Kim wrote:
>> Now zap_pte_range alwayas activates pages which are pte_young &&
>> !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED,
>> it's unnecessary since the page wouldn't use any more.
>>
>> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx>
>> Acked-by: Rik van Riel <riel@xxxxxxxxxx>
>> Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
>> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
>> Cc: Nick Piggin <npiggin@xxxxxxxxx>
>> Cc: Mel Gorman <mel@xxxxxxxxx>
>> Cc: Wu Fengguang <fengguang.wu@xxxxxxxxx>
>>
>> Changelog since v2:
>> - remove unnecessary description
>> Changelog since v1:
>> - change word from promote to activate
>> - add activate argument to zap_pte_range and family function
>>
>> ---
>> include/linux/mm.h | 4 ++--
>> mm/madvise.c | 4 ++--
>> mm/memory.c | 38 +++++++++++++++++++++++---------------
>> mm/mmap.c | 4 ++--
>> 4 files changed, 29 insertions(+), 21 deletions(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index e097df6..6032881 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -779,11 +779,11 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
>> int zap_vma_ptes(struct vm_area_struct *vma, unsigned long address,
>> unsigned long size);
>> unsigned long zap_page_range(struct vm_area_struct *vma, unsigned long address,
>> - unsigned long size, struct zap_details *);
>> + unsigned long size, struct zap_details *, bool activate);
>
> I would prefer naming the parameter 'ignore_references' or something
> similar, so that it reflects the immediate effect on the zappers'
> behaviour, not what mark_page_accessed() might end up doing.
>
> Other than that, the patch looks good to me.
Fair enough.
Will fix.
Maybe it would take a long time until sending next version.
Thanks, Hannes.
>
> Hannes
>
--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/