Re: [PATCH 8/8] Add yaffs2 file system: VFS glue code, hook intokernel tree building

From: Nick Piggin
Date: Wed Dec 01 2010 - 00:30:38 EST


On Wed, Dec 1, 2010 at 8:57 AM, Charles Manning <cdhmanning@xxxxxxxxx> wrote:

> +#define UnlockPage(p) unlock_page(p)
> +#define Page_Uptodate(page)    test_bit(PG_uptodate, &(page)->flags)

You should never be testing page flags by hand, outside mm code.

Why aren't you using PageUptodate()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/