Re: [Patch] bonding: clean up netpoll code

[Cong Wang]

On 12/01/10 16:03, Eric Dumazet wrote:
> Le mercredi 01 dÃcembre 2010 Ã 02:45 -0500, Amerigo Wang a Ãcrit :
> > Against net-next-2.6.
> >
> > This patch unifies the netpoll code in bonding with netpoll code in bridge,
> > thanks to Herbert that code is much cleaner now.
> >
> > It also removes the flag IFF_IN_NETPOLL, we don't need it any more since
> > we have netpoll_tx_running() now.
> >
> > It passes my basic testings.
>
> Sorry this NETPOLL patch is frightening...
>
> Could you split it in several parts ?
>
> The removal of IFF_IN_NETPOLL deserves a patch on its own, its not a
> cleanup at all, if you ask me.

Is this necessary?
It is just replacing checking IFF_IN_NETPOLL with netpoll_tx_running(),
you might need to take a look at the bridge code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/