Re: [PATCH 2/2] perf tools: fix event parsing of comma-separatedtracepoint events

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxx> wrote:

> From: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> 
> There are number of issues that prevent the use of multiple tracepoint events
> being specified in a -e/--event switch, separated by commas.
> 
> For example, perf stat -e irq:irq_handler_entry,irq:irq_handler_exit ...  fails
> because the tracepoint event parsing code doesn't recognize the comma separator
> properly.
> 
> This patch corrects those issues.

One other thing we seem to have forgotten in the perf stat area: could we please 
make Stephane's --big-num feature the default for perf stat? Big numbers are much 
easier to read that way:

Before:

aldebaran:~> perf stat ./loop_100b_instructions

 Performance counter stats for './loop_100b_instructions':

       23958.911461  task-clock-msecs         #      0.998 CPUs 
                 50  context-switches         #      0.000 M/sec
                  2  CPU-migrations           #      0.000 M/sec
                106  page-faults              #      0.000 M/sec
        76647095433  cycles                   #   3199.106 M/sec
       110471119457  instructions             #      1.441 IPC  
        10116354483  branches                 #    422.238 M/sec
             518642  branch-misses            #      0.005 %    
             220770  cache-references         #      0.009 M/sec
              81657  cache-misses             #      0.003 M/sec

       24.006780937  seconds time elapsed

After:

aldebaran:~> perf stat --big-num ./loop_100b_instructions

 Performance counter stats for './loop_100b_instructions':

       23869.990497  task-clock-msecs         #      0.998 CPUs 
                 58  context-switches         #      0.000 M/sec
                 43  CPU-migrations           #      0.000 M/sec
                106  page-faults              #      0.000 M/sec
     76,338,390,893  cycles                   #   3198.091 M/sec
    110,473,163,060  instructions             #      1.447 IPC  
     10,114,252,456  branches                 #    423.723 M/sec
          1,290,825  branch-misses            #      0.013 %    
          1,713,770  cache-references         #      0.072 M/sec
            188,051  cache-misses             #      0.008 M/sec

       23.917757467  seconds time elapsed

perf stat output isnt an ABI.

(Btw., we should probably also add tabular output for scripts. I thought we had that 
- but apparently not.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/