RE: [PATCH] net/r8169: Remove the firmware of RTL8111D

[hayeswang]

Hi Romieu,

the rtl8168d_3_hw_phy_config is RTL8111DP which is different from RTL8111D(L).
I want to deal with RTL8111D first.

The attatched file is the linux-firmware patch.

I would think the situation for the failure of request_firmware. However, maybe
it is fine to go along.

Thanks for your suggestion and reply.
 
Best Regards,
Hayes


> -----Original Message-----
> From: Francois Romieu [mailto:romieu@xxxxxxxxxxxxx] 
> Sent: Wednesday, December 01, 2010 4:08 PM
> To: Hayeswang
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Ben 
> Hutchings
> Subject: Re: [PATCH] net/r8169: Remove the firmware of RTL8111D
> 
> Hayes Wang <hayeswang@xxxxxxxxxxx> :
> > Remove the firmware of RTL8111D from the kernel.
> > The binary file of firmware would be moved to 
> linux-firmware repository.
> 
> The driver can not simply go along when request_firmware 
> fails. Though Ben's
> code did not take care of it, the driver should imho 
> propagate some return
> code. Ben ?
> 
> There is no change in rtl8168d_3_hw_phy_config : could you 
> add a comment
> so that people know it is different ?
> 
> Could you Cc: the linux-firmware patch as well ?
> 
> Minor nit: please keep the code free of capitalized hex data.
> 
> > diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> > index 7d33ef4..cad1ba8 100644
> > --- a/drivers/net/r8169.c
> > +++ b/drivers/net/r8169.c
> [...]
> > @@ -1383,6 +1384,28 @@ static void rtl_phy_write(void 
> __iomem *ioaddr, const struct phy_reg *regs, int
> >  	}
> >  }
> >  
> > +static void rtl_phy_write_fw(void __iomem *ioaddr, const 
> struct firmware *fw)
> > +{
> [...]
> > +		default:
> > +			printk(KERN_WARNING "%s: Unknown action\n",
> > +				__FUNCTION__);
> 
> A bit old school. It gives no information about the device.
> Use netif_{err/info} or such ?
> 
> Thanks.
> 
> -- 
> Ueimor
> 
> 
> ------Please consider the environment before printing this e-mail. 
> 
> 
>

Attachment: 0001-rtl_nic-Add-firmware-for-RTL8111D-L.patch
Description: Binary data