Re: [PATCH v2] add netdev led trigger

[Andi Kleen]

On Tue, Nov 30, 2010 at 07:03:00PM -0500, Eric Cooper wrote:
> On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andi Kleen wrote:
> > Using the device name as an identifier is not reliable, they may not
> > be unique.
> 
> I'm confused about this -- how else can the user specify the desired network
> interface?

For presenting the user the name is probably still the best, but internally
better use the interface index.
> 
> > rwlocks are deprecated.
> 
> In favor of what?  Should I use a spinlock?

spinlocks or mutexes.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/