Re: [PATCH] rbd: replace the rbd sysfs interface

[Greg KH]

On Wed, Dec 01, 2010 at 12:08:15PM -0800, Sage Weil wrote:
> On Wed, 1 Dec 2010, Greg KH wrote:
> > >  /sys/bus/rbd/{add,remove}
> > >  /sys/bus/rbd/devices/<devid>/                 <-- struct device
> > >  /sys/bus/rbd/devices/<devid>/{some dev attrs}
> > >  /sys/bus/rbd/devices/<devid>/snap_<snapid>/   <-- struct device
> > >  /sys/bus/rbd/devices/<devid>/snap_<snapid>/{some snap attrs}
> > > 
> > > This works, and I is (I hope) using struct device properly.  The only 
> > > problem, purely from a user interface standpoint, is that the snaps are 
> > > mixed in with attributes, so anybody wanting to iterate over snaps needs 
> > > to do something crufty like
> > > 
> > >  $ for snap in `ls /sys/bus/rbd/devices/$id | grep ^snap_ | cut -c 6-`; do ...
> > 
> > What's wrong with:
> > 	for snap in `ls /sys/bus/rbd/devices/$id/snap_*`; do ...
> > instead?
> 
> Yeah, it's really the 'cut -c 6-' bit that I was hoping to avoid.  But it 
> snaps/ simply doesn't map onto the sysfs paradigm cleanly, that's fine.
> 
> That being the case, can we get an Acked-by on the current approach/patch?  

Yes, please feel free to add:
	Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx> to the patch.

> Then I can send something Linus and let him decide what to do for .37.

It's pretty late for .37.  Why not disable the option for now, and then
get this patch in for .38 as it's quite a big change?  I'd recommend
doing that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/