Re: [PATCH v3 2/3]set timeout control reg for such SDHCI host

[Wolfram Sang]

On Thu, Dec 02, 2010 at 07:26:13PM +0800, Chuanxiao Dong wrote:

> +	if (host->quirks & SDHCI_QUIRK_FORCE_ERASE_SINGLE) {
> +		/* Set the timeout to be the maximum value */
> +		if (cmd->erase_timeout)
> +			sdhci_writeb(host, 0xE, SDHCI_TIMEOUT_CONTROL);
> +	}
> +
>  	sdhci_writew(host, SDHCI_MAKE_CMD(cmd->opcode, flags), SDHCI_COMMAND);

Hmm, this looks like another argument for Philip's idea to always use
the maximum timeout value and skip the quirks related to it?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature