Re: [PATCH] Bug in scripts/package/mkspec?

[Michal Marek]

On 18.11.2010 19:13, Patrick LeBoutillier wrote:
> Hi all,
> 
> I've been building RPMs for the Linux kernel for a while now and only
> recently noticed that the RPM Release field is always set to 1.
> After a bit of searching I found the offending line in
> scripts/package/mkspec. Here is a patch that worked for me, but
> perhaps this
> could be fixed in better way by someone knowledgeable of the kernel
> build process...:
> 
> 
> --- ./mkspec.next       2010-11-18 13:08:56.000000000 -0500
> +++ mkspec      2010-11-18 13:10:13.000000000 -0500
> @@ -29,7 +29,7 @@
>  echo "Version: $__KERNELRELEASE"
>  # we need to determine the NEXT version number so that uname and
>  # rpm -q will agree
> -echo "Release: `. $srctree/scripts/mkversion`"
> +echo "Release: `cd $srctree && ./scripts/mkversion`"

This doesn't look correct to me, the script reads the .version file
which is in the build directory, not in the source dir. Can you post a
step-by-step reproducer for your bug?

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/