Re: [PATCH 7/8] perf timechart: Map power:cpu_idle events to the corresponding cpuidle state

From: Thomas Renninger
Date: Thu Dec 02 2010 - 11:51:47 EST


On Thursday 02 December 2010 17:42:27 Thomas Renninger wrote:
> Before, power:cpu_idle events were very specific X86 Intel mwait events.
> This got fixed with previous patches and cpu_idle events are now thrown by
> all cpuidle drivers and can be mapped to the corresponding cpuidle state
> in /sys.
>
> This patch reads out the corresponding cpuidle name of a cpu_idle event
> and uses it in the title line of the chart (c-states Cx in x86, omap2
> - DDR self refresh states for various arm archs).
>
> It also reads out the corresponding abbr(eviation) and uses the string
> to draw the cpu idle occurences. This needs a short (3 letter) string
> to keep the overview in the chart.

I forgot two other changes:
- Fixes black c-state drawings in eog and firefox:
class="rect.cX" is wrong and must be class="cX"
- Use green color instead of red for idle drawings. This does not clash
with the Block IO drawings (also red) and better fits the "green IT"
background the C-states are about :) (that was not really the reason,
green was one of the last not used colors)...

Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/