RE: [PATCH v4 0/4]implement eMMC4.4 standard HW reset feature

[Dong, Chuanxiao]

Hello all,
How about these patches? It implemented HW reset feature. When card occurred a timeout error during reading/writing/erasing, these patches will allow driver to reset eMMC card by trigger a HW reset signal.
Does anyone have any comments about the implementation of these patches? Wolfram and Arnd already pointed out the unsuitable patch headers. Thanks! :)


> -----Original Message-----
> From: linux-mmc-owner@xxxxxxxxxxxxxxx
> [mailto:linux-mmc-owner@xxxxxxxxxxxxxxx] On Behalf Of Chuanxiao Dong
> Sent: Wednesday, December 01, 2010 8:49 PM
> To: linux-mmc@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; cjb@xxxxxxxxxx; arjan@xxxxxxxxxxxxxxx;
> alan@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH v4 0/4]implement eMMC4.4 standard HW reset feature
> 
> Hi,
> 	These are the version 4 patches to implement eMMC4.4 HW reset
> 	feature. Host controller can use this feature by trigger RST_n signal.
> 	To enable this, byte 162 of EXT_CSD register should be set.
> 	HW reset is implemented in mmc core layer and sdhci host layer, and it
> 	will be used after each reading/writing/erasing timeout error occures.
> 
> 	change-log:
> 	This version change the way to detect timeout error conditions. Added a
> 	new routine mmc_handle_timeout_error to do this instead to do this in
> 	mmc_wait_for_req. Each timeout read/write/erase command can use this
> 	routine to do HW reset.
> 
> 	patch1: enable HW reset capability if card support.
> 
> 	patch2: add two new callback to implement HW reset in mmc core layer. In
> 	this patch, routine mmc_handle_timeout_error was added.
> 
> 	patch3: implement hardware_reset callback for sdhci host. A new callback
> 	reset_emmc was defined which will be each sdhci host controller to
> 	implement separately.
> 
> 	patch4: did a HW reset after each read/write/erase command.
> 
> Thanks
> Chuanxiao
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/