Re: [linux-pm] [PATCH] PM / Hibernate: Restore old swap signature to avoid user space breakage

[Rafael J. Wysocki]

On Monday, December 06, 2010, Karel Zak wrote:
> On Mon, Dec 06, 2010 at 10:36:55AM +1100, Bojan Smojver wrote:
> > On Sun, 2010-12-05 at 23:24 +0100, Rafael J. Wysocki wrote:
> > > Commit 3624eb0 (PM / Hibernate: Modify signature used to mark swap)
> > > modified hibernate signature used to mark swap partitions containing
> > > hibernation images, but that turns out to have caused problems in
> > > libblkid on recent Ubuntu.  Restore the old signature to avoid those
> > > problems. 
> > 
> > Don't quite understand this change (sorry, probably just being obtuse).
> 
>  I too.
> 
> > The signature was changed to make sure older kernels don't handle
> > compressed images by accident, right? If so, this would seem like a bad
> > idea, because this is what can actually happen now.
> > 
> > Shouldn't user space learn how to handle both signatures instead?
> 
>  The upstream libblkid has been updated, there is not a problem to
>  support more signatures.

Cool.

I'm withdrawing the patch, then.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/