Re: [patch 1/4] vt-d: quirk for masking vtd spec errors toplatform error handling logic

[Max Asbock]

On Mon, 2010-12-06 at 13:02 -0800, Suresh Siddha wrote:
> On Mon, 2010-12-06 at 12:44 -0800, Jesse Barnes wrote:
> > On Mon, 06 Dec 2010 12:26:30 -0800
> > Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:
> > 
> > > On Mon, 2010-12-06 at 09:27 -0800, Jesse Barnes wrote:
> > > > Can we make these registers and bits a bit more self-documenting (i.e.
> > > > #defines for both, maybe along with other useful bit definitions for
> > > > this reg)? Also, "error" is misspelled as "erorr" above. :)
> > > 
> > > Thanks for the review. Appended the updated patch. I haven't used
> > > #defines for the pci-id's, as the first one (IOH) is used by several
> > > chipsets and the second one is not named yet.
> > 
> > Is there a bug # that should be referenced in the commit log?  Any
> > tested-bys to add?
> 
> There is no kernel.org bug# but there are multiple bugs with different
> OSV's. And hence didn't care to mention to the bug #
> 
> Please add:
> 
> Reported-by: Max Asbock <masbock@xxxxxxxxxxxxxxxxxx>
> Reported-and-tested-by: Takao Indoh <indou.takao@xxxxxxxxxxxxxx>
> Acked-by: Chris Wright <chrisw@xxxxxxxxxxxx>
> Acked-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>
> 

I tested the patches on a system with a Tylersburg chipset. I used the
patches against the 2.6.37-rc4 kernel and tested kdump. I still see the
Vt-d errors but they no longer cause NMIs. It works as expected. 

- Max

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/