Re: [RFC][PATCH 03/10] workqueue: It is likely that WORKER_NOT_RUNNINGis true

[Tejun Heo]

Hello, Steven.

On 12/07/2010 02:58 AM, Steven Rostedt wrote:
> In worker_thread() we have:
> 
> 	worker_clr_flags(worker, WORKER_PREP);
> 
> 	[ do work stuff ]
> 
> 	worker_set_flags(worker, WORKER_PREP, false);
> 
> (that 'false' means not to wake up an idle worker)
> 
> The wq_worker_sleeping() is called from schedule when a worker thread
> is putting itself to sleep. Which happens most of the time outside
> of that [ do work stuff ].

Yeah, I was lost thinking about the busiest case where workers are
busy processing works consecutively.  Usually workers are of course
switching in and out of idle state all the time.

How about just dropping likely/unlikely?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/