Re: [PATCH 29/29] drivers/regulator: Update WARN uses

From: Mark Brown
Date: Tue Dec 07 2010 - 06:43:59 EST


On Mon, Dec 06, 2010 at 02:05:19PM -0800, Joe Perches wrote:
> Align arguments.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

but please do remember to send patches to maintainers - trying to merge
patches without going through the maintainers means that people working
on the actual tree concerned may either replicate your work or introduce
conflicts with your patches, neither of which is good.

Not cutting the patch for Liam's benefit:

> ---
> drivers/regulator/core.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index a1b1237..5d07e5d 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1379,8 +1379,7 @@ static int _regulator_disable(struct regulator_dev *rdev,
> *supply_rdev_ptr = NULL;
>
> if (WARN(rdev->use_count <= 0,
> - "unbalanced disables for %s\n",
> - rdev_get_name(rdev)))
> + "unbalanced disables for %s\n", rdev_get_name(rdev)))
> return -EIO;
>
> /* are we the last user and permitted to disable ? */
> --
> 1.7.3.2.245.g03276.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/