Re: [PATCH 29/29] drivers/regulator: Update WARN uses

From: Liam Girdwood
Date: Tue Dec 07 2010 - 10:44:20 EST


On Tue, 2010-12-07 at 16:31 +0100, Jiri Kosina wrote:
> On Tue, 7 Dec 2010, Mark Brown wrote:
>
> > > > > Align arguments.
> >
> > > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> >
> > > > Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> >
> > > > but please do remember to send patches to maintainers - trying to merge
> > > > patches without going through the maintainers means that people working
> > > > on the actual tree concerned may either replicate your work or introduce
> > > > conflicts with your patches, neither of which is good.
> >
> > > That happened here:
> >
> > > https://lkml.org/lkml/2010/11/1/107
> >
> > > but the patch is not in linux-next after more than one month. Which is why
> > > Joe is resending it for inclusion through my queue.
> >
> > That's not a reason to drop people from the CCs when reposting, and when
> > reposting it's always good to include any reviews you got previously.
>
> Yes, collecting of the previously collected Acked-by: would definitely be
> good. Joe, could you please include it next time?
>
> > Indeed, looking at the original posting you'll see he sent it directly
> > to you first time around as well as CCing the maintainers.
>
> Yes, but I am not merging these large series which span gazillion of
> subsystems at first. I only tend to act as a fallback for those parts of
> the series which were not merged by maintainers.
>
Sorry, this is my fault. I've been very busy lately and this one slipped
through. I can take it now if you want ?

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/