Re: [PATCH v3 4/5] msm: hotplug: support cpu hotplug on msm

[Catalin Marinas]

On 13 December 2010 01:20,  <ykaoua@xxxxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/arch/arm/mach-msm/hotplug.c
[...]
> +static inline void platform_do_lowpower(unsigned int cpu)
> +{
> + Â Â Â /* Just enter wfe for now. */
> + Â Â Â for (;;) {
> + Â Â Â Â Â Â Â asm("wfe");
> + Â Â Â Â Â Â Â if (pen_release == cpu) {
> + Â Â Â Â Â Â Â Â Â Â Â /*
> + Â Â Â Â Â Â Â Â Â Â Â Â* OK, proper wakeup, we're done
> + Â Â Â Â Â Â Â Â Â Â Â Â*/
> + Â Â Â Â Â Â Â Â Â Â Â break;
> + Â Â Â Â Â Â Â }
> + Â Â Â Â Â Â Â smp_rmb();

Do you need some barrier after wfe?

-- 
Catalin
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—