Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmallocon initialize

[Jesper Juhl]

On Mon, 13 Dec 2010, Hank Janssen wrote:

> Correct issue with not checking kmalloc return value.
> This fix now only uses one receive buffer for all hv_utils 
> channels, and will do only one kmalloc on init and will return
> with a -ENOMEM if kmalloc fails on initialize.
> 
> And properly clean up memory on failure.
> 
> Thanks to Evgeniy Polyakov <zbr@xxxxxxxxxxx> for pointing this out.
> And thanks to Jesper Juhl <jj@xxxxxxxxxxxxx> and Ky Srinivasan 
> <ksrinivasan@xxxxxxxxxx> for suggesting a better implementation of
> my original patch.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Signed-off-by: Hank Janssen <hjanssen@xxxxxxxxxxxxx>
> Cc: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
> Cc: Jesper Juhl <jj@xxxxxxxxxxxxx>
> Cc: Ky Srinivasan <ksrinivasan@xxxxxxxxxx>
> 

I can't spot any problems with these changes now, so feel free to add
  Reviewed-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
if you like.


-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/