Re: [PATCH v2] Staging: rt2860: include KERN_* in printk

[Greg KH]

On Mon, Dec 13, 2010 at 01:53:12PM -0800, Joe Perches wrote:
> On Mon, 2010-12-13 at 13:15 -0800, Greg KH wrote:
> > On Mon, Dec 13, 2010 at 09:24:30PM +0100, L. Alberto Giménez wrote:
> > > +#define DBGPRINT_ERR(fmt, args...) printk(KERN_ERR fmt, ##args)
> > > Recommended by Joe. I agree that it is cleaner and more compliant.
> > Not really, it should be replaced with dev_err() or some such universal
> > replacement.
> 
> It's used with and without access to a struct device.
> 
> The uses that have a struct device available should be
> dev_<foo> and with a struct net_device should be netdev_<foo>
> though that's a wider change.
> 
> It's also used in consecutive calls without newline where
> KERN_CONT should be used instead.
>  
> Greg, you replied to the list but not the sender.
> Please don't drop the sender.

If you look at the original message I responded to, the sender asked
_not_ to be included based on the headers of the message, so my email
client did the correct thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/