Re: [PATCHv6 4/4] omap: iommu - create new api to set valid da range

[Felipe Contreras]

On Tue, Dec 14, 2010 at 8:59 PM, Guzman Lugo, Fernando
<fernando.lugo@xxxxxx> wrote:
> On Tue, Dec 14, 2010 at 9:08 AM, Felipe Contreras
> <felipe.contreras@xxxxxxxxx> wrote:
>> On Tue, Dec 14, 2010 at 3:07 PM, Fernando Guzman Lugo
>> <fernando.lugo@xxxxxx> wrote:
>>> From: Guzman Lugo, Fernando <x0095840@xxxxxx>
>>>
>>> Some IOMMUs cannot use the whole 0x0 - 0xFFFFFFFF rage.
>>> With this new API the valid range can be set.
>>>
>>> Signed-off-by: Fernando Guzman Lugo <x0095840@xxxxxx>
>>> Acked-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx>
>>
>> I still don't see where this API is being used.
>
> you can find it here:
>
> http://marc.info/?l=linux-kernel&m=128805403014740&w=2

Oh, ok, thanks. somehow I missed it.

>> Also, the point of using platform data was to add it to omap3_devices
>> in omap-iommu.c, see[1]. I thought the platform data start/end would
>> move to struct iommu, and iommu_set_da_range would change the
>> start/end on struct iommu, but that would only be necessary if the
>> platform data doesn't match that.
>
> it is not clear for me. do you mean having default start/end in
> platform data then when iommu_get is call pass them to start/end in
> struct iommu and the new api change start/end in struct iommu?
>
> Please let me know if that is correct.

Yeah, if you are not going to add it in the platform data
(mach-omap2/omap-iommu.c), then it doesn't make sense to use platform
data for that.

Cheers.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/