Re: [tip:sched/core] sched: Add 'autogroup' scheduling feature:automated per session task groups
From: Oleg Nesterov
Date: Thu Dec 16 2010 - 10:15:47 EST
On 12/16, Mike Galbraith wrote:
>
> I'd also have to disable interrupts though,
Even irq_disable can't help, I think.
> so may as well just lock it.
this also looks simpler.
> I didn't do the -ESRCH or no display bit. As far as autogroup is
> concerned, if you couldn't lock, it's history, so belongs to init.
Agreed. I considered this option too, but I was worried about
sched_group_set_shares(root).
However, as you pointed out,
> sched_group_set_shares() does the right thing, says no to changing the
> root task group's shares.
Aha, I see, thanks.
I believe the patch is correct and closes the hole.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/