Re: [PATCH 2/3] spi: mpc52xx_psc_spi: fix section mismatch warning

From: Grant Likely
Date: Thu Dec 16 2010 - 12:24:05 EST


On Thu, Dec 16, 2010 at 10:13 AM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote:
> Done by using of_probe_platform_driver() instead of
> of_register_platform_driver().
>
> Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

Move the probe hook to the __devinit section instead.

g.

> ---
>  drivers/spi/mpc52xx_psc_spi.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/mpc52xx_psc_spi.c b/drivers/spi/mpc52xx_psc_spi.c
> index 983fbbf..4bf6d37 100644
> --- a/drivers/spi/mpc52xx_psc_spi.c
> +++ b/drivers/spi/mpc52xx_psc_spi.c
> @@ -509,7 +509,6 @@ static const struct of_device_id mpc52xx_psc_spi_of_match[] = {
>  MODULE_DEVICE_TABLE(of, mpc52xx_psc_spi_of_match);
>
>  static struct of_platform_driver mpc52xx_psc_spi_of_driver = {
> -       .probe = mpc52xx_psc_spi_of_probe,
>        .remove = __exit_p(mpc52xx_psc_spi_of_remove),
>        .driver = {
>                .name = "mpc52xx-psc-spi",
> @@ -520,7 +519,8 @@ static struct of_platform_driver mpc52xx_psc_spi_of_driver = {
>
>  static int __init mpc52xx_psc_spi_init(void)
>  {
> -       return of_register_platform_driver(&mpc52xx_psc_spi_of_driver);
> +       return of_probe_platform_driver(&mpc52xx_psc_spi_of_driver,
> +                                       mpc52xx_psc_spi_of_probe);
>  }
>  module_init(mpc52xx_psc_spi_init);
>
> --
> 1.7.2.3
>
>



--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/