Re: [PATCH] proc: warn if registering world writeable files

[Alexey Dobriyan]

On Thu, Dec 16, 2010 at 04:26:10PM -0500, Dave Jones wrote:
> On Thu, Dec 16, 2010 at 10:32:17PM +0200, Alexey Dobriyan wrote:
>  > +	WARN_ON(S_ISREG(mode) && (mode & S_IWOTH));
>  >  	ent->mode = mode;
>  >  	ent->nlink = nlink;
>  >  	atomic_set(&ent->count, 1);
> 
> Not sure about this. For the reason I mentioned in the checkpatch diff
> that this is "usually" a problem.  There may be some use cases where
> it may actually be ok.
> 
> (I'm having a hard time thinking up a justification though tbh)

Me too.

If it's for quick debugging, one can reassign ->mode after registering and
escape the warning.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/