Re: [PATCH 2/2] Fix checkpatch issues in file s626.c

[Dan Carpenter]

On Fri, Dec 17, 2010 at 10:51:33AM +0200, Xenofon Foukas wrote:
> This patch fixes line over 80 characters warnings
> in file s626.c

I don't really think it's worthwhile to do this.  In my opinion, the
original long lines are more readable than the new ones.

Long lines are a bad thing because they show that the coders don't know
what they are doing.  But chopping the lines into smaller lines is like
painting over a person who has small pox.  It doesn't fix the problem.

There are a couple other problems with this patch.

The subject should say:
[PATCH 2/2] Staging: comedi: Fix checkpatch issues in file s626.c

The patch changes places that say:
	DEBUG("foo");
to:
	printk(KERN_DEBUG "foo");

The trick with the DEBUG() macro is that it normally doesn't print
anything by default because it's compiled out.  This patch makes it
compiled in always.

You didn't describe that change in the changelog.

Also the indenting in the new patch isn't always the right.  The
multi-line commenting style isn't right.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/