Re: [RFC 1/5] user namespaces: Add a user_namespace ascreator/owner of uts_namespace

From: Serge Hallyn
Date: Fri Dec 17 2010 - 11:12:17 EST


Quoting Alexey Dobriyan (adobriyan@xxxxxxxxx):
> On Fri, Dec 17, 2010 at 5:24 PM, Serge E. Hallyn <serge@xxxxxxxxxx> wrote:
> > +/*
> > + * userns count is 1 for root user, 1 for init_uts_ns,
> > + * and 1 for... ?
> > + */
> >  struct user_namespace init_user_ns = {
> >        .kref = {
> > -               .refcount       = ATOMIC_INIT(2),
> > +               .refcount       = ATOMIC_INIT(3),
>
> +1 is for init_nsproxy ;-)

Hmm, actually user_namespace isn't in struct nsproxy any more,
since 18b6e0414e42d95183f07d8177e3ff0241abd825.

I think my original thought was that init_user_ns is pinned twice by
root_user - once as creator and once as the root user in it. In
which case it isn't right - the user_ns pins the task which created
it, the creator does not pin the user_ns it creates.

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/