Re: [RFC] [PATCH 2.6.37-rc5-tip 18/20] 18: uprobes: commonly usedfilters.

From: Srikar Dronamraju
Date: Fri Dec 17 2010 - 22:07:13 EST


* Valdis.Kletnieks@xxxxxx <Valdis.Kletnieks@xxxxxx> [2010-12-17 14:32:59]:

> On Thu, 16 Dec 2010 15:30:49 +0530, Srikar Dronamraju said:
>
> > Provides most commonly used filters. Prevents users from having to define
> > their own filters. However this would be useful once we can
> > dynamically associate a filter with a uprobe-event tracer.
>
> Unclear/awkward language here...
>
> Did you mean "Prevents users from defining their own filters" or "Allows
> users to not have to define their own filters"?

The later one. From my perspective, users would prefer to filter
based on tid, pid, sid. So by defining these common/generic filters
within uprobes, we help users from not having to redine these
filters. However it no way prevents users from defining their
filters. Also users can still go ahead and add a filter for the same
purpose for which we already have defined a filter.

If you think user would like to filter based on some other
parameter that most users would be interested, then do let me know,
I will try to add a filter for the same.

--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/