Re: [PATCH] Input: introduce device information ioctl

[Henrik Rydberg]

On Fri, Dec 17, 2010 at 11:39:36AM -0800, Dmitry Torokhov wrote:
> On Thu, Dec 16, 2010 at 09:30:13PM +0100, Henrik Rydberg wrote:
> > Today, userspace sets up an input device based on the data it emits.
> > This is not always enough; a tablet and a touchscreen may emit exactly
> > the same data, for instance, but the former should be set up with a
> > pointer whereas the latter does not need to. Recently, a new type of
> > touchpad has emerged where the buttons are under the pad, which
> > changes handling logic without changing the emitted data. This patch
> > introduces a new ioctl, EVIOCGPROP, which enables user access to a set
> > of device properties useful during setup. The properties are given as
> > a bitmap in the same fashion as the event types, and are also made
> > available via sysfs.
> > 
> 
> Looks good to me.
> 
> Could you please also wire up /proc/bus/input/devices to show new
> 'props' (I think we could use  "B: PROP=" tags for them) and also to the
> uevent handler?

Sure thing. Regarding the devices file, it would have been nice if an
entry could be used to reproduce the device exactly. Currently, the
ABS limits are missing. Should we add them as well?

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/