RE: [PATCH] leds-lp5521: modify the way of setting led device name
From: Arun MURTHY
Date: Sun Dec 19 2010 - 05:59:22 EST
Hi Andrew,
Since Richard is not active in the community, can you please push this
patch through your mm tree.
Thanks and Regards,
Arun R Murthy
--------------
> -----Original Message-----
> From: Onkalo Samu [mailto:samu.p.onkalo@xxxxxxxxx]
> Sent: Thursday, December 16, 2010 6:37 PM
> To: Arun MURTHY
> Cc: akpm@xxxxxxxxxxxxxxxxxxxx; rpurdie@xxxxxxxxx; Linus WALLEIJ; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] leds-lp5521: modify the way of setting led device
> name
>
> On Wed, 2010-12-15 at 17:25 +0530, ext Arun Murthy wrote:
> > Currently the led device name is fetched from the device_type in
> > I2C_BOARD_INFO which comes from the platform data. This name is in
> turn
> > used to create an entry in sysfs.
> >
> > If there exists two or more lp5521 on a particular platform, the
> > device_type in I2C_BOARD_INFO has to be the same, else lp5521 driver
> > probe wont be called and if used so, results in run time warning
> "cannot
> > create sysfs with same name" and hence a failure.
> >
> > The name that is used to create sysfs entry is to be passed by the
> > struct led_platform_data. Hence adding an element of type const char
> *
> > and change in lp5521 driver to use this name in creating the led
> device
> > if present else use the name obtained by I2C_BOARD_INFO.
> >
> > Signed-off-by: Arun Murthy <arun.murthy@xxxxxxxxxxxxxx>
>
> Looks ok.
>
> I'll make similar patch for lp5523 at some point.
>
> Acked-by: Samu Onkalo <samu.p.onkalo@xxxxxxxxx>
N§²æìr¸yúèØb²X¬¶ÇvØ^)Þ{.nÇ+·¥{±êçzX§¶¡Ü}©²ÆzÚ&j:+v¨¾«êçzZ+Ê+zf£¢·h§~Ûiÿûàz¹®w¥¢¸?¨èÚ&¢)ßfù^jÇy§m
á@A«a¶Úÿ0¶ìh®åi