Re: [PATCH] mm: add replace_page_cache_page() function

From: KAMEZAWA Hiroyuki
Date: Sun Dec 19 2010 - 19:00:33 EST


On Fri, 17 Dec 2010 16:51:44 +0100
Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> On Fri, 17 Dec 2010, KAMEZAWA Hiroyuki wrote:
> > No. memory cgroup expects all pages should be found on LRU. But, IIUC,
> > pages on this radix-tree will not be on LRU. So, memory cgroup can't find
> > it at destroying cgroup and can't reduce "usage" of resource to be 0.
> > This makes rmdir() returns -EBUSY.
>
> Oh, right. Yes, the page will be on the LRU (it needs to be,
> otherwise the VM coulnd't reclaim it). After the
> add_to_page_cache_locked is this:
>
> if (!(buf->flags & PIPE_BUF_FLAG_LRU))
> lru_cache_add_file(newpage);
>
> It will add the page to the LRU, unless it's already on it.
>

Thank you for clarification.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/