Re: [PATCH 01/12] libiscsi: Convert to host_lock less w/ interruptsdisabled internally

From: Mike Christie
Date: Mon Dec 20 2010 - 19:43:24 EST


On 12/19/2010 03:21 PM, Nicholas A. Bellinger wrote:
prepd_fault:
@@ -1732,12 +1728,10 @@ fault:
scsi_out(sc)->resid = scsi_out(sc)->length;
scsi_in(sc)->resid = scsi_in(sc)->length;
}
- done(sc);
- spin_lock(host->host_lock);
+ sc->scsi_done(sc);
return 0;


Did you mean to send this patch or a different one? I think you sent a patch with this before and I said it was wrong. Did you disagree with that comment or did you change something else so it now works?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/