Re: [PATCH 1/1] power: bq20z75: Update return value of CURRENT NOW

[Anton Vorontsov]

On Mon, Dec 20, 2010 at 04:54:22PM -0800, rklein wrote:
> On Tue, 2010-12-14 at 19:04 -0800, Olof Johansson wrote:
> > On Tue, Dec 14, 2010 at 05:01:25PM -0800, rklein wrote:
> > > The BQ20Z75 will return a negative value for current if the battery is
> > > discharging and a positive value if charging. This should always be
> > > exported
> > > as a positive number.
> > >
> > > Signed-off-by: Rhyland Klein <rklein@xxxxxxxxxx>
> > 
> > Reviewed-by: Olof Johansson <olof@xxxxxxxxx>
> > 
> > -Olof
> 
> Anton, is this patch ok to get put in?

I'm not sure. Probably not. Why would you think that the current
should always be positive? For ds2760 it isn't, for example.
If some driver assumes always positive current, I think it should
be fixed instead.

If the battery is discharging, let it be negative. That's what
happens on wires anyway. :-)

-- 
Anton Vorontsov
Email: cbouatmailru@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/