Re: [PATCH v3] USB: add support for Dream Cheeky DL100B WebmailNotifier (1d34:0004)

From: Greg KH
Date: Tue Dec 21 2010 - 23:50:58 EST


On Wed, Dec 22, 2010 at 02:04:33AM +0100, Melchior FRANZ wrote:
> Same as v2, except:
> - version number removed from usbled.c file header
> - garbage removed from corrupted diff (sorry about that)
>
>
> Please review yet again and consider for inclusion. (The patch is diffed
> against 2.6.36.2.)

I've applied this, but I now get the following build warning:

drivers/usb/misc/usbled.c: In function âchange_colorâ:
drivers/usb/misc/usbled.c:48:6: warning: âretvalâ may be used uninitialized in this function

Care to send a follow-on patch to fix this up? Just set retval to 0 at
the start of that function and it should be fine.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/