Re: [PATCH V7 1/8] ntp: add ADJ_SETOFFSET mode bit

[Richard Cochran]

On Tue, Dec 21, 2010 at 02:25:55PM -0800, john stultz wrote:
> On Wed, 2010-12-22 at 05:57 +0900, Kuwahara,T. wrote:
> 
> > How about this?
> > 
> > if (txc->modes & ADJ_OFFSET) {
> > 	if (txc->constant == INT32_MIN) {
> > 		/* step time */
> > 	} else {
> > 		/* slew time */
> > 	}
> > }
> 
> This looks like magic behavior. Sort of a "knock twice and then say the
> password" interface. I don't see why that would be better then adding a
> clear new mode flag?

I have to agree with John on this one. Looks very hacky to me.

Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/