Re: [PATCH v2 2/6] MFD MAX8998/LP3974: Support LP3974 RTC

From: Mark Brown
Date: Wed Dec 22 2010 - 08:25:28 EST


On Wed, Dec 22, 2010 at 03:23:07PM +0900, MyungJoo Ham wrote:

> before reading it. If the device name is "lp3974-regerr", the rtc driver
> assumes that such delays are required. If the device name is "lp3974",
> the rtc driver does not. Although we have not seen LP3974s without
> requiring such delays, we assume that such LP3974s will be released
> soon (or they have done so already) and they are supported by "lp3974".

Might a bit of platform data not be a more robust way of passing this
in? If we use the device name then it'd be difficult to handle other
issues in future.

It's a shame the affected devices can't be identified at runtime :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/