Re: [tip:perf/core] perf probe: Don't always consider EOF as anerror when listing source code

[Arnaldo Carvalho de Melo]

Em Wed, Dec 22, 2010 at 02:14:43PM +0100, Franck Bui-Huu escreveu:
> tip-bot for Franck Bui-Huu <fbuihuu@xxxxxxxxx> writes:
> >  error:
> > -	if (feof(fp))
> > +	if (ferror(fp)) {
> >  		pr_warning("Source file is shorter than expected.\n");
> > -	else
> > -		pr_warning("File read error: %s\n", strerror(errno));
> > +		return -1;
> 
> Argh, something wrong here.
> 
> The warning left here, is the wrong one, I should have left the other
> one.
> 
> Sorry for the mistake.
> 
> Should I send a patch to fix that ?

Please.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/